Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add polyfill for Intl.Segmenter #3795

Merged
merged 8 commits into from
Aug 2, 2023
Merged

fix: add polyfill for Intl.Segmenter #3795

merged 8 commits into from
Aug 2, 2023

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Aug 2, 2023 •
edited

This closes #3204, closes #3609.

@codesandbox
Copy link

codesandbox bot commented Aug 2, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Aug 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 1:52pm
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 1:52pm

@fourdim fourdim linked an issue Aug 2, 2023 that may be closed by this pull request
Cannot delete any character using backspace in firefox #3609
Closed
@fourdim fourdim marked this pull request as draft August 2, 2023 05:34
@fourdim fourdim marked this pull request as ready for review August 2, 2023 07:28
@fourdim fourdim marked this pull request as draft August 2, 2023 07:33
@fourdim fourdim marked this pull request as ready for review August 2, 2023 12:32
@fourdim fourdim requested review from doodlewind and himself65 and removed request for doodlewind August 2, 2023 12:32
doodlewind
doodlewind reviewed Aug 2, 2023
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
himself65
himself65 suggested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be only handled in the playground and AFFiNE

@fourdim
Copy link
Contributor Author

fourdim commented Aug 2, 2023

I think this should be only handled in the playground and AFFiNE

Do you mean remove polyfillIntlSegmenter(); from these files?

packages/blocks/src/__internal__/utils/selection.ts
packages/store/src/workspace/indexer/search.ts
packages/virgo/src/utils/transform-input.ts

@himself65
Copy link
Contributor

I think this should be only handled in the playground and AFFiNE

Do you mean remove polyfillIntlSegmenter(); from these files?

packages/blocks/src/internal/utils/selection.ts packages/store/src/workspace/indexer/search.ts packages/virgo/src/utils/transform-input.ts

yes

@fourdim fourdim requested a review from himself65 August 2, 2023 16:01
@himself65 himself65 merged commit bdf398b into toeverything:master Aug 2, 2023
15 checks passed
This was referenced Aug 3, 2023
Closed
Closed
@fourdim fourdim deleted the polyfill-segmenter branch August 3, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind left review comments

@himself65 himself65 himself65 approved these changes

Assignees

@fourdim fourdim

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot delete any character using backspace in firefox backspace doesn't work in firefox
3 participants
@fourdim @himself65 @doodlewind