feat: embed-youtube, embed-github, new-bookmark card views and toolbar #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Svaney-ssman
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Problems:
1.
- Hide the embed icon when a link can not turn into embed view
- Disable vertical views in page mode, check design
- Edit menu has not yet been synchronized with the design
- Hide inline view then a bookmark in edgeless mode, inline view only show in page modecheck design here
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
7eb5ae7
to
ef54f70
Compare
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
ef54f70
to
8403acd
Compare
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
8403acd
to
1110bf4
Compare
AyushAgrawal-A2
changed the title
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
455c5c2
to
92427ba
Compare
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
999cc0b
to
e55a986
Compare
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
46359b7
to
ff5af62
Compare
AyushAgrawal-A2
force-pushed
the
ayush/new-bookmark
branch
from
ef685b2
to
bdba167
Compare
Flrande
approved these changes
Jan 9, 2024
hwangdev97
approved these changes
Jan 10, 2024
hwangdev97
approved these changes
Jan 10, 2024
Svaney-ssman
approved these changes
Jan 10, 2024
doodlewind
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
p.s. : open graph data will not be visible in vercel deploys