feat: embed-linked-page card views and toolbar #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
AyushAgrawal-A2
changed the title
AyushAgrawal-A2
force-pushed
the
ayush/5713
branch
from
60c9747
to
4604756
Compare
AyushAgrawal-A2
requested review from
houjoe0829,
hwangdev97 and
Svaney-ssman
|
This is a bug when I drag a deleted page from the note then turn into a large vertical view |
|
The placeholder images are not correct when I convert from horizontal view to vertical view, but correct after duplicate |
AyushAgrawal-A2
force-pushed
the
ayush/5713
branch
from
ff021ae
to
155b710
Compare
houjoe0829
approved these changes
Jan 11, 2024
AyushAgrawal-A2
force-pushed
the
ayush/5713
branch
from
6f46770
to
02f32d1
Compare
Flrande
approved these changes
Jan 12, 2024
doodlewind
reviewed
Jan 12, 2024
There was a problem hiding this comment.
I think we need to rename the all embed-linked-page block type to embed-linked-doc due to product naming change from @houjoe0829.
We can land this PR and have the naming change in further PR. The naming update won't be considered as breaking change before there is visible entry for users. So we can make this happen without writing migration rules.
AyushAgrawal-A2
force-pushed
the
ayush/5713
branch
from
c936402
to
3a43f93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5713
Linked Page Playground Demo
Changes: