Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sync): initialize @blocksuite/sync #6204

Merged
merged 7 commits into from
Feb 19, 2024
Merged

feat(sync): initialize @blocksuite/sync #6204

merged 7 commits into from
Feb 19, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 6, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 2:28am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 2:28am

@EYHN EYHN marked this pull request as ready for review February 6, 2024 16:38
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Feb 6, 2024
@doodlewind doodlewind changed the title feat(sync): initial @blocksuite/sync feat(sync): initialize @blocksuite/sync Feb 6, 2024
@EYHN EYHN requested a review from Flrande February 7, 2024 04:33
@Flrande
Copy link
Member

Flrande commented Feb 14, 2024 •
edited

I made some refactoring and adjustments based on the original.

  • Adjusted some concept naming of the sync package.
  1. SyncEngine -> DocEngine
  2. shared -> shadow
  3. storage -> source
  • Adjusted the file structure, the current structure is as follows.
- sync package
  - awareness engine
    - impl // default implementations
  - doc engine
    - impl
  - blob engine // TODO
    - impl // TODO
  • Removed the old provider implementation from the playground, completely rewritten based on the sync package, and removed async-call-rpc

cc @EYHN @doodlewind

@Flrande Flrande merged commit 362c82d into master Feb 19, 2024
19 checks passed
@Flrande Flrande deleted the eyhn/feat/sync branch February 19, 2024 02:31
This was referenced Feb 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@doodlewind doodlewind Awaiting requested review from doodlewind doodlewind is a code owner

@Flrande Flrande Awaiting requested review from Flrande

Assignees

@EYHN EYHN

Labels
notable Major improvement worth emphasizing
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EYHN @Flrande @Saul-Mirone @doodlewind