Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump blocksuite #5845

Merged

Conversation

AyushAgrawal-A2
Copy link
Contributor

Features

Bugfix

Refactor

Misc

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as draft February 20, 2024 09:38
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app package:y-indexeddb test Related to test cases app:core labels Feb 20, 2024
Copy link

nx-cloud bot commented Feb 20, 2024

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3881164) 65.22% compared to head (3b9c745) 65.16%.
Report is 13 commits behind head on canary.

Files Patch % Lines
packages/frontend/core/src/hooks/use-journal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5845      +/-   ##
==========================================
- Coverage   65.22%   65.16%   -0.07%     
==========================================
  Files         348      348              
  Lines       19675    19670       -5     
  Branches     1657     1660       +3     
==========================================
- Hits        12833    12817      -16     
- Misses       6621     6632      +11     
  Partials      221      221              
Flag Coverage Δ
server-test 71.35% <ø> (-0.11%) ⬇️
unittest 46.84% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyushAgrawal-A2
Copy link
Contributor Author

Changes:

  • Added blocksuite awareness flag for synced doc block, enabled for canary
  • Added setupEditorFlags to workspace manager

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as ready for review February 20, 2024 11:12
Copy link

graphite-app bot commented Feb 20, 2024

Merge activity

@Brooooooklyn Brooooooklyn merged commit 6fad241 into toeverything:canary Feb 20, 2024
33 of 35 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/bumpBlocksuite20022024 branch February 20, 2024 12:56
Brooooooklyn pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:env mod:infra Environment related issues and discussions mod:workspace-impl package:y-indexeddb test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants