Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): active eventDispatcher when edgeless tool updated #6234

Merged

Conversation

donteatfriedrice
Copy link
Member

Active event dispatcher when edgeless tool updated if current event dispatcher is inactive, otherwise some tool controller event like pointerMove would not be dispatched and the tool overlay would not be displayed when first time switch to edgeless mode.

before:

Screen.Recording.2024-02-20.at.11.29.10.mov

after:

Screen.Recording.2024-02-20.at.11.29.40.mov

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:39am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 3:39am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doodlewind doodlewind merged commit c35aff3 into toeverything:master Feb 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants