-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename page to doc #6290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyushAgrawal-A2
requested review from
Saul-Mirone and
doodlewind
as code owners
February 23, 2024 17:52
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 23, 2024 18:27
3ee907d
to
9688d6e
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 23, 2024 19:07
9688d6e
to
3d2cb27
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 23, 2024 19:16
3d2cb27
to
fa9b29a
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 23, 2024 19:40
fa9b29a
to
876c88d
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 24, 2024 08:49
876c88d
to
c8cc45c
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 24, 2024 08:54
c8cc45c
to
f7fe5ae
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 24, 2024 09:04
960bb95
to
f4325fa
Compare
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 26, 2024 09:58
cf5b1d7
to
7f89c5b
Compare
AyushAgrawal-A2
requested review from
Flrande,
doouding,
fourdim,
donteatfriedrice,
regischen,
EYHN,
zzj3720 and
lawvs
February 26, 2024 10:00
AyushAgrawal-A2
force-pushed
the
ayush/6214
branch
from
February 26, 2024 11:38
7f89c5b
to
be5976e
Compare
doodlewind
approved these changes
Feb 27, 2024
doodlewind
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have double checked that this doesn't break data, we'll hand over and focus on the next step bumping AFFiNE.
ununian
pushed a commit
to ununian/blocksuite
that referenced
this pull request
Feb 27, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOV-561
closes #6214
Before this pr, we have
Page
(store),PageBlock
(havingpage
andedgeless
views)pageMode
(havepage
andedgeless
mode)To avoid any confusion due to name overlap, I have renamed:
Page
(store) toDoc
PageBlock
toRootBlock
, (this is in line with syntaxdoc.root
&doc.slots.rootAddedOn
. flavour is still "affine:page")pageMode
toeditorMode
, having 2 modes -page
,edgeless
So now -
page
editorMode.edgeless
editorMode.Exception -
pageId
is renamed todocId
, (everywhere, except in block props & snapshot payload)pageVersion
&pages
properties inWorkspaceMetaState
page
property inBlockModel
(this is marked as deprecated and expected usage is viadoc
getter and setter)Change log - https://app.affine.pro/share/63a1780d-ee20-4b7f-ac70-f254e4154120/rduRN-2fxFklR-nLSZVYe