Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump blocksuite #5953

Merged
merged 2 commits into from
Feb 29, 2024
Merged

feat: bump blocksuite #5953

merged 2 commits into from
Feb 29, 2024

Conversation

regischen
Copy link
Member

Features

Bugfix

Refactor

Misc

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app package:y-indexeddb test Related to test cases app:core mod:workspace-impl labels Feb 29, 2024
Copy link

nx-cloud bot commented Feb 29, 2024

@regischen regischen changed the title feat: bump blocksuite chore: bump blocksuite Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 48.93617% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 63.83%. Comparing base (3432f35) to head (8d41b2f).
Report is 1 commits behind head on canary.

Files Patch % Lines
...ontend/core/src/hooks/use-block-suite-page-meta.ts 16.66% 5 Missing ⚠️
.../modules/workspace/properties/legacy-properties.ts 0.00% 5 Missing ⚠️
packages/common/infra/src/initialization/index.ts 0.00% 4 Missing ⚠️
packages/frontend/core/src/hooks/use-journal.ts 0.00% 4 Missing ⚠️
packages/common/infra/src/page/record.ts 25.00% 3 Missing ⚠️
...ommon/infra/src/blocksuite/migration/blocksuite.ts 0.00% 1 Missing ⚠️
...common/infra/src/blocksuite/migration/workspace.ts 50.00% 0 Missing and 1 partial ⚠️
.../src/hooks/use-block-suite-workspace-page-title.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5953   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         364      364           
  Lines       20032    20032           
  Branches     1699     1699           
=======================================
  Hits        12788    12788           
  Misses       7027     7027           
  Partials      217      217           
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 43.97% <48.93%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doodlewind doodlewind changed the title chore: bump blocksuite feat: bump blocksuite Feb 29, 2024
Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has renamed some page to doc, but there are still many places using page. We can gradually modify it to doc in the future.

@regischen
Copy link
Member Author

This PR has renamed some page to doc, but there are still many places using page. We can gradually modify it to doc in the future.

Yeah, It mainly works on the page from blocksuite to doc. But there are still many local variables called page.

@EYHN EYHN merged commit d1e6b23 into canary Feb 29, 2024
32 of 36 checks passed
@EYHN EYHN deleted the 0229/bump branch February 29, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:env mod:infra Environment related issues and discussions mod:workspace-impl package:y-indexeddb test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants