Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): add default text color of shape-element #6300

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(edgeless): add default text color of shape-element #6300

merged 1 commit into from
Feb 27, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Feb 26, 2024

Before

Screenshot 2024-02-26 at 16 29 24

After

Screenshot 2024-02-26 at 16 28 36

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 10:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 10:46am

doouding
doouding reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@doouding doouding left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's a good idea to set a CSS variable as a fallback value 'cause that means in order to render an element with a fallback property you need to set a proper CSS variable in advance.

Or assign the CSS variable as the field initialization.

@fundon fundon changed the title fix(edgeless): color of shape-element should be --affine-palette-line-black as a fallback fix(edgeless): add default text color of shape-element Feb 27, 2024
@fundon fundon requested a review from doouding February 27, 2024 10:45
@doouding doouding merged commit 568b233 into toeverything:master Feb 27, 2024
20 checks passed
@fundon fundon deleted the fix-shape-text-color branch February 27, 2024 11:13
@regischen regischen mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doouding doouding doouding approved these changes

Assignees

@fundon fundon

Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fundon @doouding