feat(database): column stats

[golok727]

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	❌ Failed (Inspect)			Apr 10, 2024 3:02pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
blocksuite-docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 10, 2024 3:02pm

[golok727]

@zzj3720 Hey some help🙏🏻, why does datasource.onCellUpdate is inconsistent with different property types? rich text and title is using ytext observe and others are using model.propsChanges in data source. due to this the callback given to onCellUpdate is called for all the columns when a cell is updated. Also is it not getting called for richtext cells.
Is this intended behaviour as I only want to compute the stats for the updated columns

[zzj3720]

@zzj3720 Hey some help🙏🏻, why does datasource.onCellUpdate is inconsistent with different property types? rich text and title is using ytext observe and others are using model.propsChanges in data source. due to this the callback given to onCellUpdate is called for all the columns when a cell is updated. Also is it not getting called for richtext cells. Is this intended behaviour as I only want to compute the stats for the updated columns

Listening for updates on columns is challenging; I need to think about it.

[zzj3720]

@golok727 I think we can temporarily set aside the issue of listening for updates on the title column and fix it later. If the statistics functionality is completed, we can add a feature flag to merge it first and then optimize it. I might be doing some adjustments and refactoring to the directory structure soon, so if this task drags on too long, it might be difficult to merge.

[golok727]

@golok727 I think we can temporarily set aside the issue of listening for updates on the title column and fix it later. If the statistics functionality is completed, we can add a feature flag to merge it first and then optimize it. I might be doing some adjustments and refactoring to the directory structure soon, so if this task drags on too long, it might be difficult to merge.

The core functionality is finished; I'll refine it by making the statCalcOp optional, integrating the feature flag as discussed, and ensuring the PR is ready for review by this evening. Thanks!

[Saul-Mirone]

Waiting for @zzj3720 to review this.

[graphite-app]

Merge activity

• Apr 10, 11:02 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 10, 11:08 AM EDT: zzj3720 added this pull request to the Graphite merge queue.
• Apr 10, 11:12 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
• Apr 10, 11:12 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 10, 11:12 AM EDT: zzj3720 added this pull request to the Graphite merge queue.
• Apr 10, 3:12 PM UTC: graphite-app removed this pull request from the Graphite merge queue.
• Apr 10, 3:12 PM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue