Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): lasso tool should consider rotation and fallback to ray-casting #6716

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

golok727
Copy link
Contributor

@golok727 golok727 commented Apr 9, 2024

Provides a better selection algorithm for the lasso tool.

fix.mp4

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 8:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 8:03am

@golok727
Copy link
Contributor Author

golok727 commented Apr 9, 2024

@doouding PTAL

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link

graphite-app bot commented Apr 10, 2024

Merge activity

  • Apr 9, 9:20 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 9, 9:20 PM EDT: doodlewind added this pull request to the Graphite merge queue.
  • Apr 9, 9:24 PM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.
  • Apr 10, 4:01 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 10, 4:07 AM EDT: Flrande added this pull request to the Graphite merge queue.
  • Apr 10, 4:10 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to internal failures.

@graphite-app graphite-app bot removed the merge label Apr 10, 2024
@Flrande Flrande added the merge label Apr 10, 2024
@graphite-app graphite-app bot removed the merge label Apr 10, 2024
@Flrande Flrande merged commit 7b6def2 into toeverything:master Apr 10, 2024
19 checks passed
@golok727 golok727 deleted the radhu/fix_lasso_rotated_models branch April 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants