Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connectors resize #6704

Closed
wants to merge 3 commits into from
Closed

fix: connectors resize #6704

wants to merge 3 commits into from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Apr 8, 2024

Related to #6652

  • standalone connectors
  • standalone connectors and other shapes
  • connectors and associated shapes
  • connectors but no associated shapes
  • other cases
Screen.Recording.2024-04-08.at.23.08.43.mov

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 7:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 7:50am

Copy link

graphite-app bot commented Apr 8, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Apr 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon closed this Jun 10, 2024
@fundon fundon deleted the 03_31-fix-connectors-resize branch June 10, 2024 09:36
fundon added a commit that referenced this pull request Jun 12, 2024
Closes [BS-454](https://linear.app/affine-design/issue/BS-454/connector-resize-and-rotate)
Related to #6704

In the connectors scenario, just recalculate `source.position` and `target.position`.
Extract independent functions to resize elements.

> Maybe we can move these into their servies.

https://github.com/toeverything/blocksuite/assets/27926/ace30ee4-9b77-4962-8e49-8ada544ada63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant