Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): selection when all elements are connectors #6652

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 29, 2024

Closes: BS-94

Copy link

graphite-app bot commented Mar 29, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 11:51am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:51am

Copy link
Contributor Author

fundon commented Mar 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from da767de to 9934068 Compare March 29, 2024 16:41
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from 9934068 to 09a2ec7 Compare March 29, 2024 18:10
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from 09a2ec7 to 5f9080b Compare March 30, 2024 05:59
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from 5f9080b to ce0589d Compare March 30, 2024 09:29
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from ce0589d to 27bdbc6 Compare March 31, 2024 06:28
@fundon fundon changed the title fix(edgeless): selection when all elements are connector fix(edgeless): selection when all elements are connectors Mar 31, 2024
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from 27bdbc6 to 77dccd9 Compare March 31, 2024 06:30
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from e1e8686 to 288b8a4 Compare March 31, 2024 07:05
@fundon fundon marked this pull request as ready for review March 31, 2024 07:06
@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from 288b8a4 to e907d83 Compare March 31, 2024 07:09
@fundon
Copy link
Contributor Author

fundon commented Mar 31, 2024

The next PR will fix the resize connectors.

@Saul-Mirone
Copy link
Collaborator

@fundon seem there're some conflicts.

@fundon

This comment was marked as resolved.

@fundon fundon force-pushed the 03_30-fix-connectors-selected-rect branch from b9a4080 to 6c9c052 Compare April 1, 2024 11:48
@Saul-Mirone Saul-Mirone merged commit e5049eb into master Apr 1, 2024
19 checks passed
@Saul-Mirone Saul-Mirone deleted the 03_30-fix-connectors-selected-rect branch April 1, 2024 12:31
Saul-Mirone pushed a commit that referenced this pull request Apr 1, 2024
Related to #6652

Sorry, the previous PR did not correctly resolve the conflict.
@fundon fundon mentioned this pull request Apr 9, 2024
5 tasks
darkskygit pushed a commit to toeverything/AFFiNE that referenced this pull request Apr 10, 2024
## Features
- toeverything/blocksuite#6679 @pengx17
- toeverything/blocksuite#6620 @doouding
- toeverything/blocksuite#6602 @golok727
- toeverything/blocksuite#6661 @Flrande
- toeverything/blocksuite#6591 @fundon
- toeverything/blocksuite#6634 @golok727
- toeverything/blocksuite#6626 @regischen
- toeverything/blocksuite#6630 @Saul-Mirone
- toeverything/blocksuite#6605 @donteatfriedrice
- toeverything/blocksuite#6614 @zzj3720
- toeverything/blocksuite#6508 @doouding
- toeverything/blocksuite#6578 @donteatfriedrice
- toeverything/blocksuite#6572 @zzj3720
- toeverything/blocksuite#6571 @golok727
- toeverything/blocksuite#6573 @fundon
- toeverything/blocksuite#6580 @Flrande
- toeverything/blocksuite#6540 @golok727
- toeverything/blocksuite#6567 @Flrande
- toeverything/blocksuite#6565 @zzj3720
- toeverything/blocksuite#6561 @zzj3720

## Bugfix
- toeverything/blocksuite#6677 @donteatfriedrice
- toeverything/blocksuite#6681 @fundon
- toeverything/blocksuite#6673 @fundon
- toeverything/blocksuite#6652 @fundon
- toeverything/blocksuite#6641 @fourdim
- toeverything/blocksuite#6649 @golok727
- toeverything/blocksuite#6648 @doouding
- toeverything/blocksuite#6662 @Flrande
- toeverything/blocksuite#6659 @zkwolf
- toeverything/blocksuite#6644 @doouding
- toeverything/blocksuite#6633 @golok727
- toeverything/blocksuite#6632 @golok727
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6600 @fourdim
- toeverything/blocksuite#6617 @zzj3720
- toeverything/blocksuite#6618 @Flrande
- toeverything/blocksuite#6576 @fundon
- toeverything/blocksuite#6595 @fundon
- toeverything/blocksuite#6596 @zzj3720
- toeverything/blocksuite#6574 @fundon
- toeverything/blocksuite#6593 @Saul-Mirone
- toeverything/blocksuite#6588 @zzj3720
- toeverything/blocksuite#6590 @zzj3720
- toeverything/blocksuite#6589 @zzj3720
- toeverything/blocksuite#6584 @lawvs
- toeverything/blocksuite#6579 @fundon
- toeverything/blocksuite#6538 @golok727
- toeverything/blocksuite#6570 @zzj3720
- toeverything/blocksuite#6569 @zzj3720
- toeverything/blocksuite#6564 @zzj3720
- toeverything/blocksuite#6563 @zzj3720

## Refactor
- toeverything/blocksuite#6683 @doodlewind
- toeverything/blocksuite#6668 @Flrande
- toeverything/blocksuite#6635 @donteatfriedrice
- toeverything/blocksuite#6653 @fundon
- toeverything/blocksuite#6615 @Flrande
- toeverything/blocksuite#6534 @Saul-Mirone
- toeverything/blocksuite#6553 @golok727

## Misc
- chore(examples): cleanup types
- toeverything/blocksuite#6664 @fourdim
- toeverything/blocksuite#6657 @fourdim
- toeverything/blocksuite#6654 @fourdim
- toeverything/blocksuite#6587 @Saul-Mirone
- toeverything/blocksuite#6562 @donteatfriedrice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants