Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edgeless copilot discard modal #6769

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Apr 16, 2024

When need to close the ai panel directly, call panel.hide().

When need to confirm with the user and do some callback processing before closing the panel, set discardCallback to the panel and call panel.discard()

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 5:12am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 5:12am

Copy link

graphite-app bot commented Apr 16, 2024

Merge activity

  • Apr 16, 1:05 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 16, 1:05 AM EDT: donteatfriedrice added this pull request to the Graphite merge queue.
  • Apr 16, 1:14 AM EDT: donteatfriedrice merged this pull request with the Graphite merge queue.

When need to close the ai panel directly, call panel.hide().

When need to confirm with the user and do some callback processing before closing the panel, set discardCallback to the panel and call panel.discard()
@donteatfriedrice donteatfriedrice force-pushed the fix/edgeless-copilot-discard-modal branch from 15fb6ee to 31032b3 Compare April 16, 2024 05:06
@graphite-app graphite-app bot merged commit 31032b3 into master Apr 16, 2024
19 checks passed
@graphite-app graphite-app bot deleted the fix/edgeless-copilot-discard-modal branch April 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants