Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database): can't scroll in database side details #6851

Merged
merged 8 commits into from
Apr 25, 2024
Merged

fix(database): can't scroll in database side details #6851

merged 8 commits into from
Apr 25, 2024

Conversation

golok727
Copy link
Contributor

@golok727 golok727 commented Apr 23, 2024 •
edited

fix.mp4

close #6693

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 3:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:59am

@golok727 golok727 changed the title fix(database): can't scroll in side layout modal fix(database): can't scroll in database side details Apr 23, 2024
@donteatfriedrice
Copy link
Member

Hey @zzj3720, @hwangdev97, @doodlewind, this seems a bit off in AFFiNE. Shouldn't we adjust it to fit the viewport instead of keeping it relative to the database?

issue.mp4

I guess the position issue has been fixed by #6588

@golok727 golok727 mentioned this pull request Apr 23, 2024
Open
1 task
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 25, 2024 •
edited

Merge activity

@donteatfriedrice donteatfriedrice enabled auto-merge (squash) April 25, 2024 03:53
@donteatfriedrice donteatfriedrice merged commit 5e090a9 into toeverything:master Apr 25, 2024
18 of 19 checks passed
@EYHN EYHN mentioned this pull request Apr 25, 2024
Merged
@golok727 golok727 deleted the radhu/fix/database-side-layout-modal branch April 25, 2024 04:54
pengx17 pushed a commit to toeverything/AFFiNE that referenced this pull request Apr 25, 2024
@EYHN
chore: bump blocksuite (#6694)
20a0d0b 
## Features
- toeverything/blocksuite#6863 @regischen
- toeverything/blocksuite#6852 @doouding
- toeverything/blocksuite#6860 @pengx17
- toeverything/blocksuite#6856 @donteatfriedrice
- toeverything/blocksuite#6849 @fundon

## Bugfix
- toeverything/blocksuite#6873 @pengx17
- toeverything/blocksuite#6870 @golok727
- toeverything/blocksuite#6851 @golok727
- toeverything/blocksuite#6848 @pengx17
- toeverything/blocksuite#6847 @fundon
- toeverything/blocksuite#6867 @EYHN
- toeverything/blocksuite#6868 @fundon
- toeverything/blocksuite#6869 @donteatfriedrice
- toeverything/blocksuite#6865 @donteatfriedrice
- toeverything/blocksuite#6866 @fundon
- toeverything/blocksuite#6864 @donteatfriedrice
- toeverything/blocksuite#6824 @undefined
- toeverything/blocksuite#6859 @fundon
- toeverything/blocksuite#6853 @fundon
- toeverything/blocksuite#6854 @fundon
- toeverything/blocksuite#6845 @fourdim

## Refactor
- toeverything/blocksuite#6872 @fundon

## Misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzj3720 zzj3720 zzj3720 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to scroll to last column of the table database in slidelayout model
3 participants
@golok727 @donteatfriedrice @zzj3720