fix(blocks): try fix surface ref note portal stuck #6867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
EYHN
requested review from
donteatfriedrice,
doodlewind,
doouding,
Flrande,
fourdim,
regischen and
Saul-Mirone
Flrande
approved these changes
Apr 24, 2024
Merge activity
|
There is a long stuck when rendering SurfaceRefNotePortal. I noticed that we were listen to blockUpdated in render which seemed to cause too many event listeners in there.
pengx17
force-pushed
the
eyhn/fix/too-many-block-updated-listener
branch
from
fcd2e48
to
a38f767
Compare
pengx17
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Apr 25, 2024
## Features - toeverything/blocksuite#6863 @regischen - toeverything/blocksuite#6852 @doouding - toeverything/blocksuite#6860 @pengx17 - toeverything/blocksuite#6856 @donteatfriedrice - toeverything/blocksuite#6849 @fundon ## Bugfix - toeverything/blocksuite#6873 @pengx17 - toeverything/blocksuite#6870 @golok727 - toeverything/blocksuite#6851 @golok727 - toeverything/blocksuite#6848 @pengx17 - toeverything/blocksuite#6847 @fundon - toeverything/blocksuite#6867 @EYHN - toeverything/blocksuite#6868 @fundon - toeverything/blocksuite#6869 @donteatfriedrice - toeverything/blocksuite#6865 @donteatfriedrice - toeverything/blocksuite#6866 @fundon - toeverything/blocksuite#6864 @donteatfriedrice - toeverything/blocksuite#6824 @undefined - toeverything/blocksuite#6859 @fundon - toeverything/blocksuite#6853 @fundon - toeverything/blocksuite#6854 @fundon - toeverything/blocksuite#6845 @fourdim ## Refactor - toeverything/blocksuite#6872 @fundon ## Misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a long stuck when rendering SurfaceRefNotePortal. I noticed that we were listen to blockUpdated in render which seemed to cause too many event listeners in there.