Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): create popper only if more button exists #6891

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Apr 26, 2024

screenshot_2024-04-25_at_15 53 02

Copy link

graphite-app bot commented Apr 26, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 6:21am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 6:21am

Copy link
Contributor Author

fundon commented Apr 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 04_26-fix-throw-error-when-missing-mor-button branch from 61f3b93 to 7e8c004 Compare April 26, 2024 04:40
@fundon fundon marked this pull request as ready for review April 26, 2024 04:40
@fundon fundon requested a review from regischen April 26, 2024 04:41
Copy link
Member

@regischen regischen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix

Copy link

graphite-app bot commented Apr 26, 2024

Merge activity

@EYHN EYHN force-pushed the 04_26-fix-throw-error-when-missing-mor-button branch from 7e8c004 to 3f6f5b3 Compare April 26, 2024 06:11
@graphite-app graphite-app bot merged commit 3f6f5b3 into master Apr 26, 2024
17 of 19 checks passed
@graphite-app graphite-app bot deleted the 04_26-fix-throw-error-when-missing-mor-button branch April 26, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants