Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): should reset scroll top while retrying #6882

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Apr 25, 2024

Screen.Recording.2024-04-25.at.19.52.31.mov

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 2:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 2:35am

Copy link

graphite-app bot commented Apr 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Apr 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 04_25-fix-should-reset-scroll-top-when-retrying branch 2 times, most recently from 3944ea2 to 8949819 Compare April 26, 2024 02:07
@fundon fundon added the merge label Apr 26, 2024
Copy link

graphite-app bot commented Apr 26, 2024

Merge activity

  • Apr 25, 10:07 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 25, 10:19 PM EDT: fundon added this pull request to the Graphite merge queue.
  • Apr 25, 10:30 PM EDT: fundon merged this pull request with the Graphite merge queue.

@fundon fundon force-pushed the 04_25-fix-should-reset-scroll-top-when-retrying branch from 8949819 to 324a3da Compare April 26, 2024 02:23
@graphite-app graphite-app bot merged commit 324a3da into master Apr 26, 2024
18 of 19 checks passed
@graphite-app graphite-app bot deleted the 04_25-fix-should-reset-scroll-top-when-retrying branch April 26, 2024 02:30
@vercel vercel bot temporarily deployed to Production – blocksuite April 26, 2024 02:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants