feat(blocks): new smooth-corner component #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on |
This was referenced May 31, 2024
CatsJuice
force-pushed
the
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
branch
from
c3e51ee
to
c21587d
Compare
CatsJuice
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
67bb905
to
6fd8401
Compare
CatsJuice
force-pushed
the
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
branch
from
c21587d
to
2b9ee10
Compare
CatsJuice
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
6fd8401
to
78ca90c
Compare
CatsJuice
force-pushed
the
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
branch
from
2b9ee10
to
e60c194
Compare
CatsJuice
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
78ca90c
to
0558fcd
Compare
CatsJuice
force-pushed
the
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
branch
from
e60c194
to
2045f64
Compare
CatsJuice
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
0558fcd
to
8a6b167
Compare
|
A brief description would be better. |
Ok, I will add jsdoc soon |
Saul-Mirone
force-pushed
the
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
branch
from
2045f64
to
29d5857
Compare
Saul-Mirone
changed the base branch from
catsjuice/feat/separate-edgeless-toolbar-presentation-toolbar
to
master
fundon
reviewed
Jun 11, 2024
packages/blocks/src/root-block/edgeless/components/toolbar/edgeless-toolbar.ts
Outdated
Show resolved
Hide resolved
fundon
reviewed
Jun 11, 2024
| .setFrameMenuShow=${(show: boolean) => | ||
| (this.presentFrameMenuShow = show)} | ||
| ></presentation-toolbar> | ||
| ${type === 'frameNavigator' ? nothing : this._DefaultContent} |
There was a problem hiding this comment.
Probably not needed visible. nothing can be replaced with presentation-toolbar.
There was a problem hiding this comment.
Yes, but there's a lot of initialization logic in present-toolbar, so this instance is preserved here and won't be destroyed in edgeless-toolbar.
CatsJuice
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
1ca1491
to
72352c5
Compare
fundon
approved these changes
Jun 11, 2024
fundon
reviewed
Jun 11, 2024
| accessor height: number = 0; | ||
|
|
||
| get _path() { | ||
| // return curvePath(this._points); |
Merge activity
|
Saul-Mirone
force-pushed
the
catsjuice/feat/smoohing-border-radius
branch
from
3b0f6c9
to
a899d48
Compare
doouding
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 12, 2024
## Features - toeverything/blocksuite#7264 @CatsJuice - toeverything/blocksuite#7182 @CatsJuice - toeverything/blocksuite#7181 @CatsJuice ## Bugfix - toeverything/blocksuite#7273 @L-Sun - toeverything/blocksuite#7272 @doouding - toeverything/blocksuite#7263 @doouding - toeverything/blocksuite#7252 @fourdim - toeverything/blocksuite#7261 @fundon ## Refactor - toeverything/blocksuite#7271 @golok727 ## Misc - toeverything/blocksuite#7274 @Saul-Mirone - toeverything/blocksuite#7266 @Saul-Mirone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.