Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): add shape shortcut in toolbar #7330

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat(edgeless): add shape shortcut in toolbar #7330

merged 1 commit into from
Jun 18, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jun 14, 2024 •
edited
Loading

  • add shape with shortcut "S"
  • if press while dragging, change shape

@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 1:40am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 1:40am

@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 14, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CatsJuice CatsJuice mentioned this pull request Jun 14, 2024
Merged
@CatsJuice Graphite App
Copy link
Member Author

CatsJuice commented Jun 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review June 14, 2024 10:20
This was referenced Jun 15, 2024
Merged
Merged
@CatsJuice CatsJuice force-pushed the catsjuice/fix/edgeless-toolbar-shortcuts-dispose branch from de3c8d8 to 085c4a0 Compare June 15, 2024 03:11
@CatsJuice CatsJuice force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from 0b9d62c to ffcd1db Compare June 15, 2024 03:12
@CatsJuice CatsJuice force-pushed the catsjuice/fix/edgeless-toolbar-shortcuts-dispose branch from 085c4a0 to d29b0f4 Compare June 17, 2024 03:02
@CatsJuice CatsJuice force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from 2fdc6d1 to 228784c Compare June 17, 2024 03:02
@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 17, 2024 •
edited
Loading

Merge activity

  • Jun 17, 1:40 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 1:40 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Jun 17, 1:58 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Playground E2E test (1)').
  • Jun 17, 1:58 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 5:58 AM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jun 17, 8:51 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 8:51 PM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Jun 17, 9:24 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 9:46 PM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the catsjuice/fix/edgeless-toolbar-shortcuts-dispose branch from d29b0f4 to 5d6bac6 Compare June 17, 2024 05:40
@Saul-Mirone Saul-Mirone changed the base branch from catsjuice/fix/edgeless-toolbar-shortcuts-dispose to master June 17, 2024 05:50
Saul-Mirone pushed a commit that referenced this pull request Jun 17, 2024
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
ce8893e 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from 228784c to ce8893e Compare June 17, 2024 05:50
@graphite-app graphite-app bot removed the merge label Jun 17, 2024
Saul-Mirone pushed a commit that referenced this pull request Jun 18, 2024
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
482535c 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from ce8893e to 482535c Compare June 18, 2024 01:16
@graphite-app graphite-app bot removed the merge label Jun 18, 2024
Saul-Mirone pushed a commit that referenced this pull request Jun 18, 2024
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
e7d49b5 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from a01a7d8 to e7d49b5 Compare June 18, 2024 01:20
Saul-Mirone pushed a commit that referenced this pull request Jun 18, 2024
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
2ae49f7 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from e7d49b5 to 2ae49f7 Compare June 18, 2024 01:23
Saul-Mirone pushed a commit that referenced this pull request Jun 18, 2024
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
557b1fe 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from 2ae49f7 to 557b1fe Compare June 18, 2024 01:26
@CatsJuice
feat(edgeless): add shape shortcut in toolbar (#7330)
bae88e2 
- add shape with shortcut "S"
- if press while dragging, change shape
@Saul-Mirone Saul-Mirone force-pushed the catsjuice/feat/edgeless-shape-shortcut branch from 557b1fe to bae88e2 Compare June 18, 2024 01:36
@graphite-app graphite-app bot merged commit bae88e2 into master Jun 18, 2024
19 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/edgeless-shape-shortcut branch June 18, 2024 01:46
This was referenced Jun 18, 2024
Closed
Merged
L-Sun added a commit to toeverything/AFFiNE that referenced this pull request Jun 18, 2024
@L-Sun
chore: bump up blocksuite version (#7243)
9b89c9e 
## Features
- toeverything/blocksuite#7330 @CatsJuice
- toeverything/blocksuite#7348 @zzj3720

## Bugfix
- toeverything/blocksuite#7338 @akumatus
- toeverything/blocksuite#7353 @Saul-Mirone
- toeverything/blocksuite#7351 @lawvs
- toeverything/blocksuite#7357 @L-Sun
- toeverything/blocksuite#7355 @akumatus

## Misc
- toeverything/blocksuite#7352 @L-Sun
- toeverything/blocksuite#7349 @pengx17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

Assignees
No one assigned
Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CatsJuice @Saul-Mirone