fix: doc update time outdated #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
L-Sun
reviewed
Jun 26, 2024
| @@ -11,6 +11,7 @@ export interface DocMeta { | |||
| title: string; | |||
| tags: string[]; | |||
| createDate: number; | |||
| updatedDate?: number; | |||
There was a problem hiding this comment.
@doodlewind @Saul-Mirone Please take a look. This field exists on the AFFiNE side
akumatus
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 26, 2024
Fix issue [BS-603](https://linear.app/affine-design/issue/BS-603). - Move observe `blockUpdated` logic in `blocksuite-editor` component, so it can be excuted on both page-detail and center-peek mode. - Remove useless `getDocUpdatedAt` service, because blocksuite can get `docMeta` directly. toeverything/blocksuite#7434 https://github.com/toeverything/AFFiNE/assets/12724894/e01e3f97-f1d0-4d1d-a8ed-e70e27e39bdb
Saul-Mirone
approved these changes
Jun 26, 2024
Merge activity
|
Fix issue [BS-603](https://linear.app/affine-design/issue/BS-603). - get `updatedDate` from doc meta data. - Add observer for `docMetaUpdated` slot, thus the updated time on embed card can be refresh automatically. - Use `toLocaleString` to show updated date. toeverything/AFFiNE#7344 https://github.com/toeverything/blocksuite/assets/12724894/eebf9a71-1961-4b81-8afd-f60c12420b13
akumatus
force-pushed
the
fix/doc-update-at-0626
branch
from
52d1337
to
9adba83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue BS-603.
updatedDatedirectly from doc meta data.docMetaUpdatedslot, thus the updated time on embed card can be refresh automatically.toLocaleStringto show updated date.toeverything/AFFiNE#7344
2024-06-26.19.10.30.mov