Add transformers support for effects #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geny200
requested review from
Odomontois,
danslapman,
catostrophe,
FunFunFine and
oskin1
as code owners
This was referenced Apr 23, 2024
dos65
reviewed
May 6, 2024
modules/kernel/src/main/scala-3/tofu/internal/instances/ClockInstance.scala
Show resolved
Hide resolved
Transformers support for: * Clock * Sleep * TimeZone * Delay * GenRandom * GenUUID
geny200
force-pushed
the
feature/lift-effects
branch
from
0da2c14
to
6d5dcba
Compare
dos65
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I am extending the functionality for transformers as suggested in PR #1242
Transformers support for:
I plan to add support for transformers for Effects such as Timeout and Fire, but in a new PR, because there will be different logic from the current implementations