present Time & Clock in kernel #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odomontois
requested review from
catostrophe,
danslapman,
FunFunFine and
oskin1
as code owners
FunFunFine
reviewed
Jul 17, 2021
| * This is the pure equivalent of Java's `System.currentTimeMillis`, | ||
| * or of `CLOCK_REALTIME` from Linux's `clock_gettime()`. | ||
| */ | ||
| def realTime(unit: TimeUnit): F[Long] |
There was a problem hiding this comment.
If tofu will have its own Clock typeclass, so why should it be exactly like cats one? Is it possible to fix some of the design problems e.g. not having information on units of measurement in the signature (ce3 style with FiniteDuration for example (but rather something better))?
There was a problem hiding this comment.
You have some specific design in mind?
FunFunFine
reviewed
Jul 17, 2021
FunFunFine
reviewed
Jul 17, 2021
FunFunFine
reviewed
Jul 17, 2021
| @@ -58,25 +55,6 @@ object Atom { | |||
| } | |||
| } | |||
|
|
|||
| final case class AtomByRef[F[_], A](ref: Ref[F, A]) extends Atom[F, A] { | |||
There was a problem hiding this comment.
These changes were in #709, so I guess there is something wrong with branches 🤔
FunFunFine
approved these changes
Jul 17, 2021
catostrophe
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also based on #709