use modern config handling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks compatibility with Elixir versions prior to 1.11.
kelvinst
approved these changes
Apr 1, 2024
Closed
|
@kelvinst Any idea what's wrong with the test? 🤔 |
|
@lukyanov no idea, but maybe it has to do with this message in the |
|
Ah, it's the same on master too apparently. So I'm merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use the
Configmodule. Breaks compatibility with Elixir versions prior to 1.11. At this point, 1.11 is three years old, so it's probably safe to do this. (And, if not, old versions of this package still work just fine.)