fix typespec for Holidefs.Definition.Rule #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed and function keys specified as being of function type. Code pretty clearly returns atoms or nil. Also added nil to type for function_modifier, as it's optional.
kelvinst
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observedandfunctionkeys specified as being offunctiontype. Code pretty clearly returns an atom ornil. Also addednilto type forfunction_modifier, as it's optional.This was causing a whole bunch of Dialyzer failures which were leaking out to my code downstream.
This is a reformulated branch for the fix in PR #42. The original PR unfortunately leaked some unrelated changes in. This new, clean branch should be correct. I'll close the old one.