Skip to content

Commit

Permalink
fix(settings): Fix issues with integration checkboxes
Browse files Browse the repository at this point in the history
Integrations sharing the same host could be shown as enabled even if they are not. The permission is requested on the full domain, but the list of origins in the UI would ignore the subdomains. Change the integration list to respect subdomain when creating the list of origins. Closes #1728.
  • Loading branch information
tcrammond committed Jun 25, 2020
1 parent 3bbcc94 commit d883dc3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/scripts/settings.js
Expand Up @@ -351,9 +351,7 @@ const Settings = {
.replace('*://*.', '')
.replace('*://', '')
.replace('/*', '');
if (url.split('.').length > 2) {
name = url.substr(url.indexOf('.') + 1);
}

Settings.origins[name] = {
id: i,
origin: origins[i],
Expand Down

0 comments on commit d883dc3

Please sign in to comment.