Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shortcut): Fix timer not starting when there's no project #2227

Merged
merged 1 commit into from Jul 6, 2023
Merged

fix(shortcut): Fix timer not starting when there's no project #2227

merged 1 commit into from Jul 6, 2023

Conversation

Alissonsz
Copy link
Contributor

@Alissonsz Alissonsz commented Jun 29, 2023 •
edited

馃専 What does this PR do?

馃悰 Recommendations for testing

  • Check if it's now possible to start a timer on shortcut in a storie without project

馃摑 Links to relevant issues or information

Closes toggl/track-extension-core#618

@Alissonsz Alissonsz self-assigned this Jun 29, 2023
@Alissonsz Alissonsz requested a review from hazem3500 July 5, 2023 15:09
hazem3500
hazem3500 approved these changes Jul 6, 2023
View reviewed changes
Copy link

@hazem3500 hazem3500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I've tested 馃憞

Export-1688652827766.mp4

If this was the intended fix, then all looks good 馃憣

@Alissonsz Alissonsz merged commit 3eebe96 into master Jul 6, 2023
1 check failed
@Alissonsz Alissonsz deleted the fix-shortcut branch July 6, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazem3500 hazem3500 hazem3500 approved these changes

@rafaelbubach rafaelbubach Awaiting requested review from rafaelbubach

Assignees

@Alissonsz Alissonsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alissonsz @hazem3500