Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

another attempt to fix button rendering in Zendesk #2241

Merged
merged 2 commits into from Oct 16, 2023

Conversation

reignmaker
Copy link
Contributor

馃専 What does this PR do?

Zendesk's UI is a complete mess nowadays. This is another attempt to fix button rendering in Zendesk

馃悰 Recommendations for testing

All changes should be tested across Chrome and Firefox.

I put the button into the button group to the top right corner of the ticket's container, right before the filter button.
image

馃摑 Links to relevant issues or information

@reignmaker
Copy link
Contributor Author

Hi! Any review for this? Toggl button is practically hard to use with Zendesk.

Copy link
Contributor

@nunofmn nunofmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reignmaker! 馃憢

Sorry for the delay in reviewing your PR.
Unfortunately, I wasn't able to reproduce the problem. The button still shows up.
I think that Zendesk might be running several A/B tests that change the UI a lot for different users.

I added a comment suggesting yet again to duplicate the script, so that it works for the maximum number of users.

src/content/zendesk.js Show resolved Hide resolved
@edtamayo
Copy link

Case

return the code introduced in Apr 2023 as it still works for other users
@reignmaker
Copy link
Contributor Author

Hi @nunofmn!
Thank you for your review. I did not know that Zendesk's Web UI may differ for users. In that case your point on leaving the code introduced in Apr 2023 makes sense. But such way may turn the integration code into a complete mess, but, considering that the Zendesk's UI markup is already a big mess, I guess there is no other way for us.

@liisvirki
Copy link

User shared this:

I'm assuming this error here is the thing. Zendesk changed their HTML I assume? Is there any test/development version of the extension I can use and test for you?

image

@reignmaker
Copy link
Contributor Author

User shared this:

I'm assuming this error here is the thing. Zendesk changed their HTML I assume? Is there any test/development version of the extension I can use and test for you?

image

Unfortunately, your image is compressed and unreadable.

As for test/development version of the extension -- I used a production, installed in my Chrome extension by editing source files directly.

Copy link
Contributor

@nunofmn nunofmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃憤 馃殌

Thanks a lot for fixing this @reignmaker!
Now lets hope that this fixes the integration for most of the users. 馃槄

@nunofmn nunofmn merged commit d9a1fb9 into toggl:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants