Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notion): Fix Notion's page title grabbing when opened in "side peek" mode #2261

Merged
merged 1 commit into from Mar 5, 2024

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Jan 3, 2024

🌟 What does this PR do?

Fixing the following bug report.

🐛 Bug Report

If we fully open and I start the timer from a Notion page, it does grab the title. But if the page (database item) is opened in "side peek" mode, the timer does not grab the title.

Expected behavior

We must get page titles both for full-opened and "side peek" pages.

To reproduce

Steps to reproduce the behavior:

Open a database item in "side peek"
Start tracking time

🐛 Recommendations for testing

2024-01-06_08-05

2024-01-06_08-41

  1. Open Notion page in "side peek" mode.
  2. Press the Toggl Track "Start timer" button.
  3. The Notion page title should be used as the description in the Toggl Track popup.

📝 Links to relevant issues or information

Closes #2260

Copy link
Contributor

@with-shrey with-shrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@with-shrey with-shrey merged commit 2df786a into toggl:master Mar 5, 2024
@pkvach pkvach deleted the 2260/fix-notion branch March 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We don't grab Notion page titles when it is opened in "side peek"
2 participants