Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notion-calendar): Add Notion Calendar integration #2272

Merged
merged 3 commits into from Mar 5, 2024
Merged

feat(notion-calendar): Add Notion Calendar integration #2272

merged 3 commits into from Mar 5, 2024

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Jan 30, 2024

馃専 What does this PR do?

Adding integration with Notion Calendar.

Demo:

2024-01-30_01-05

2024-01-30_01-05_1

馃悰 Recommendations for testing

  • Login to Notion Calendar.
  • Select an event in the calendar.
  • The Toggl button should appear in the upper right corner.

馃摑 Links to relevant issues or information

Closes #2271

@with-shrey
Copy link
Contributor

Thanks for your contribution @pkvach

I had to made some changes for this to work within integration since we currently dont support sub domains 馃槥
But i tested this and it looks good 馃槃

@with-shrey with-shrey requested a review from niyiAO March 5, 2024 04:29
with-shrey
with-shrey approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@with-shrey with-shrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@with-shrey with-shrey merged commit ea72a28 into toggl:master Mar 5, 2024
@pkvach
Copy link
Contributor Author

pkvach commented Mar 5, 2024

Thanks for your contribution @pkvach

I had to made some changes for this to work within integration since we currently dont support sub domains 馃槥 But i tested this and it looks good 馃槃

@with-shrey
Thanks for your help 馃憤

@pkvach pkvach deleted the 2271/add-notion-calendar branch March 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@with-shrey with-shrey with-shrey approved these changes

@niyiAO niyiAO Awaiting requested review from niyiAO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration with Notion Calendar
2 participants
@pkvach @with-shrey