Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Adobe s3mock library #1178

Merged
merged 1 commit into from Apr 22, 2024
Merged

use Adobe s3mock library #1178

merged 1 commit into from Apr 22, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 27, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (fda0e51) to head (1e36afe).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1178      +/-   ##
============================================
- Coverage     55.40%   55.20%   -0.21%     
+ Complexity      930      929       -1     
============================================
  Files           180      180              
  Lines          4606     4605       -1     
  Branches        603      605       +2     
============================================
- Hits           2552     2542      -10     
- Misses         1896     1903       +7     
- Partials        158      160       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis
Copy link
Contributor Author

sullis commented Mar 27, 2024

ready for review

@sullis
Copy link
Contributor Author

sullis commented Mar 29, 2024

WDYT @bennetelli

@hennr hennr merged commit bc4ff84 into togglz:master Apr 22, 2024
3 checks passed
@hennr
Copy link
Member

hennr commented Apr 22, 2024

Thanks for your contribution, @sullis !

@sullis sullis deleted the sean/s3mock branch April 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants