Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use = with all long form flags with values. #125

Closed
wants to merge 2 commits into from
Closed

Use = with all long form flags with values. #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50060d5
Use = with all long form flags with values.
Dec 12, 2017
11d5657
Change extend to append.
Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions flent/runners.py
View file
Open in desktop
Expand Up @@ -1474,12 +1474,12 @@ def check(self):
"Please upgrade to irtt v0.9+." % irtt)

args = [irtt, 'client', '-n', '-Q',
'--timeouts', '200ms,300ms,400ms']
'--timeouts=200ms,300ms,400ms']

if self.local_bind:
args.extend(['--local', self.local_bind])
args.append("--local={}".format(self.local_bind))
elif self.settings.LOCAL_BIND:
args.extend(['--local', self.settings.LOCAL_BIND[0]])
args.append("--local={}".format(self.settings.LOCAL_BIND[0]))

if self.ip_version is not None:
args.append("-{}".format(self.ip_version))
Expand All @@ -1497,16 +1497,16 @@ def check(self):
if self.marking is not None:
try:
mk = self.marking.split(",")[0]
marking = "--dscp {}".format(self.marking_map[mk])
marking = "--dscp={}".format(self.marking_map[mk])
except (AttributeError, KeyError):
marking = "--dscp {}".format(marking)
marking = "--dscp={}".format(marking)
else:
marking = ""

if self.local_bind:
local_bind = "--local {}".format(self.local_bind)
local_bind = "--local={}".format(self.local_bind)
elif self.settings.LOCAL_BIND:
local_bind = "--local {}".format(self.settings.LOCAL_BIND[0])
local_bind = "--local={}".format(self.settings.LOCAL_BIND[0])
else:
local_bind = ""

Expand All @@ -1520,7 +1520,7 @@ def check(self):
else:
data_size = ""

self.command = "{binary} client -o - --fill rand -Q " \
self.command = "{binary} client -o - --fill=rand -Q " \
"-d {length}s -i {interval}s {ip_version} {marking} " \
"{local_bind} {data_size} {host}".format(
binary=irtt,
Expand Down