runners: Fix crash on closing object with no stdout/stderr attributes #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohojo
changed the title
If no file descriptors are passed between processes in the pickled objects, no stdout/stderr attributes will be set on the the unpickled object, which will lead to a crash because on close(). Fix this by checking if the attributes exist before closing them. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
When parsing data in the multiprocess runner, we were using an infinite-size queue for log messages from the work threads, and only reading from it after parsing finished. It seems this can lead to an OOM condition which shows up as the parsing process hanging. To fix this, limit the size of the logging queue to 10 items, and run the reading side in a separate daemon thread so we drain in continuously. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
tohojo
force-pushed
the
pickle-fix
branch
2 times, most recently
from
2930a77
to
24ff633
Compare
To be consistent across platforms and avoid problems with threading, use the 'spawn' multiprocessing mode when parsing output. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
tohojo
force-pushed
the
pickle-fix
branch
3 times, most recently
from
a9d91ca
to
e71efa4
Compare
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
…pool Make sure we've finished all parsing before shutting down the multiprocessing pool. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
|
Closing in favour of #270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no file descriptors are passed between processes in the pickled objects,
the unpickled object will lead to a crash because it's missing the
stdout/stderr attributes. Make sure we set them if no FDs are passed
through the pickle/unpickle.
Hopefully fixes #268