Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Show a message when no tabs are loaded #295

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

tohojo
Copy link
Owner

@tohojo tohojo commented Jan 17, 2024

Instead of just showing a blank screen (which can be interpreted as the GUI
hanging), when there are no data files loaded show a message hinting that data
files can be loaded from the menu.

Fixes #293

@richb-hanover
Copy link
Contributor

This is better, but let me propose a couple alternatives to the state after typing flent-gui:

  1. Instead of simply displaying "No data files loaded. Open a data file or run a new test in the menu." that window could offer buttons/links to run a test or open a file. Those buttons would have the effect of executing Ctl/Cmd-R for Run new test or Ctl/Cmd-O to open a data file. That would require one click (on either button) to get to where you want to be.

  2. When there are no data files open, simply display the "Run new test" window. (Zero clicks to show what newcomers expect.) But also permit that window to respond to the other keyboard shortcuts (Escape, Cmd-Ctl N, O, W, Q, etc.) This would close the "Run new test" window and do whatever's required by that keyboard shortcut.

This lets experienced users who want to open a file (for example) to use the same single keystroke that they would have used before. Thanks for listening.

Instead of just showing a blank screen (which can be interpreted as the GUI
hanging), when there are no data files loaded show buttons to load a data file
or run a new test.

Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
@tohojo
Copy link
Owner Author

tohojo commented Jan 17, 2024

Ah yes, good idea with the buttons. Pushed an update, how is this?

RRUL is probably the most commonly used test in Flent, so let's default to that
when running a test from the GUI.

Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
@tohojo tohojo merged commit 2fb38ed into master Jan 17, 2024
50 of 53 checks passed
@tohojo tohojo deleted the gui-empty-message branch January 17, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank window on start (Flent 2.1.1, macOS)
2 participants