Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in myfm.MyFMOrderedProbit() model #4

Closed
RafaelSterzinger opened this issue Jul 18, 2021 · 3 comments
Closed

Bug in myfm.MyFMOrderedProbit() model #4

RafaelSterzinger opened this issue Jul 18, 2021 · 3 comments

Comments

@RafaelSterzinger
Copy link

Hello Tomoki Ohtsuki,
I was following your ml-100k-extended exemplary notebook, but had problems running the myfm.MyFMOrderedProbit() model with use_date=False. The fitting works fine, but the problem arises during prediction. I tried to attach a screenshot of the error I get. I hope it worked. If not, the error I am getting is "ValueError: Relation blocks have inconsistent mapper size with case_size". In your notebook, if the use_date=False is set, then X is set to None and X_rel=test_blocks. The error message is based on this set None value. However, in the myfm.MyFMRegressor() model everything works as expected.

Thanks in advance for your help!

image

tohtsky added a commit that referenced this issue Jul 25, 2021
@tohtsky
Copy link
Owner

tohtsky commented Jul 25, 2021

Hi @RafaelSterzinger, thank you for reporting the issue and sorry for the late reply.
I could reproduce it and identified the problem!
I believe the latest commit 661037c
has fixed the issue, and I will soon make a release for the fix.

Thank you again for your help!

@tohtsky tohtsky closed this as completed Jan 30, 2022
@tohtsky
Copy link
Owner

tohtsky commented Jan 31, 2022

It took a very long time, but I could release the version 3.1.0 with the bug fixed.

@RafaelSterzinger
Copy link
Author

It took a very long time, but I could release the version 3.1.0 with the bug fixed.

Thanks, @tohtsky for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants