Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to make puppet composer module optional #13

Merged

Conversation

c33s
Copy link
Contributor

@c33s c33s commented Jun 2, 2018

willdurand/composer a hard requirement but it only provides the composer executeable. this file can be provided by other things like puppet/php or in my case by my profile::php.
to allow the user of this module to use it without requiring willdurand/composer it should be optional. which this PR is for.

@tohuwabohu
Copy link
Owner

Can you please provide a bit more context for this change? I'm not objecting it, just curious to understand the reason behind.

@c33s
Copy link
Contributor Author

c33s commented Jun 3, 2018

updated description. the ubuntu tests are failing because of a download problem of the roundcube archive, are they? is it possible to retrigger the tests?

@tohuwabohu
Copy link
Owner

@c33s You can trigger a new build on the travis CI page via the "more options", top right corner.

@c33s
Copy link
Contributor Author

c33s commented Jun 6, 2018

not possibe because i have no write access to this repo. https://stackoverflow.com/a/17624403

will try the close and reopen tactic :)

@c33s c33s closed this Jun 6, 2018
@c33s c33s reopened this Jun 6, 2018
@tohuwabohu tohuwabohu merged commit 1abe462 into tohuwabohu:master Jun 9, 2018
@tohuwabohu
Copy link
Owner

not possibe because i have no write access to this repo. https://stackoverflow.com/a/17624403

will try the close and reopen tactic :)

Ah dang, didn't know about that. Glad the workaround worked for you, will pay more attention to this next time.

@tohuwabohu
Copy link
Owner

Released as 3.4.0 to the forge, thanks heaps for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants