-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OR-1481] Add code to predeploy USDC and L2UsdcBridge contract in L2 and create genesis file #118
[OR-1481] Add code to predeploy USDC and L2UsdcBridge contract in L2 and create genesis file #118
Conversation
op-chain-ops/genesis/config.go
Outdated
storage["SignatureChecker"] = state.StorageValues{} | ||
storage["MasterMinter"] = state.StorageValues{ | ||
"_owner": config.MasterMinterOwner, | ||
"controllers": controllers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"controllers": map[any]any{
"_controller": predeploys.L2UsdcBridgeAddr,
"_worker": predeploys.L2UsdcBridgeAddr,
}
How about fix it like this?
Since controllers
is only for the L2UsdcBridge, I think it's okay to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you good idea. I will fix it!!
Is there an option if I don't want to deploy UsdcBridge? |
Great! |
"tokenName": "Bridged USDC (Tokamak Network)", | ||
"tokenSymbol": "USDC.e", | ||
"tokenCurrency": "USD", | ||
"tokenDecimals": 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like common name.
fix to usdcTokenName, usdcTokenSymbol,… or if it's values that doesn't change like WTON, you can put it in directly.
tokamak-thanos/op-chain-ops/genesis/config.go
Line 764 in e7d6fe4
storage["WTON"] = state.StorageValues{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both seem like good ideas. I think We'll have to check later to see if the USDC name can be modified or not!
@rlgns98kr @boohyung
If the name doesn't change, why not use the latter(like WTON)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems great!
Lets remove tokamak network in the token name! And about other values, I think we can fix the value! (we don't have to provide flags!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove these flags!
"tokenName": "Bridged USDC (Tokamak Network)", // -> Bridged USDC
"tokenSymbol": "USDC.e",
"tokenCurrency": "USD",
"tokenDecimals": 6,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
circle guidelines link:
https://brand.circle.com/d/M9z54TaEwsWL/stablecoins#/-/usdc-brand-guide/usdc-naming-guidelines
circle에서 제공하는 스탠다드에서는 tokenName에 Bridged USDC (company name)을 권장합니다!
토카막에서 배포할 때는 Bridged USDC (Tokamak network)가 스탠다드이지만 온디맨드를 고려했을 때 제 3자가 수정할 수 있게 하기 위해서는 혼란을 방지하고자 Bridged USDC (company name)을 유지하는 게 어떨까 생각합니다.
제 개인적인 생각이라 틀리거나 더 나은 생각이 있다면 말해주시면 감사하겠습니다!🙇♀️🙇♀️
"tokenSymbol": "USDC.e",
"tokenCurrency": "USD",
"tokenDecimals": 6,
위의 세가지는 WTON과 같이 스토리지를 사용하여 변경되지 않도록하고 tokenName은 회사 이름을 넣을 수 있도록 변경하는 방법도 있을 것 같습니다!
In the standard provided by Circle, it is recommended to use "Bridged USDC (company name)" for the tokenName!
While "Bridged USDC (Tokamak network)" is the standard when deploying on Tokamak, considering on-demand modifications by third parties, to prevent confusion, maintaining "Bridged USDC (company name)" seems reasonable.
This is just my personal opinion, and I would greatly appreciate it if you could let me know if there are any errors or better ideas! 🙇♀️🙇♀️
The following three, "tokenSymbol": "USDC.e", "tokenCurrency": "USD", "tokenDecimals": 6, could also be maintained using storage like WTON to prevent changes. Additionally, the tokenName could be changed to include the company name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't know that!
Thank you very much!
It's great!
Have you tried upgrade those smart contracts? @xxeonge |
You are correct!! Due to issues with the proxies we're using, so I considered upgrading the contracts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! 🙇🏼♂️
Thank you |
In this work, the purpose is to predeploy L2UsdcBridge.sol and FiatTokenV2_2.sol
I added the code necessary to predeploy these two contracts, and if you run make devnet-up, you can see that genesis-l2.json is changed.
+) If L1UsdcBridge is later deployed to L1, the address pre-assigned to L2UsdcBridge have to be changed.
Thank you!! 😄