Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_stream_impl 0.3.1 removes stream, try_stream, breaking async_stream =0.3.0 #58

Closed
dfreese opened this issue Apr 22, 2021 · 1 comment

Comments

@dfreese
Copy link

dfreese commented Apr 22, 2021

I had async_stream pinned to "=0.3.0", and as a result, ran into the following error:

error[E0432]: unresolved imports `async_stream_impl::stream`, `async_stream_impl::try_stream`
   --> external/raze__async_stream__0_3_0/src/lib.rs:171:29
    |
171 | pub use async_stream_impl::{stream, try_stream};
    |                             ^^^^^^  ^^^^^^^^^^ no `try_stream` in the root
    |                             |
    |                             no `stream` in the root

error: aborting due to previous error

We try to pin our main dependencies, to keep a little more control over how things update. Updating to 0.3.1 for async stream 0.3.1 isn't a problem, but should 0.3.1 have been 0.4?

@taiki-e
Copy link
Member

taiki-e commented Apr 22, 2021

async_stream_impl is Implementation detail of the async_stream crate. It is not intended to depend directly and most crates do not support updating only implementation details.

However, this issue has been fixed in 0.3.1 (#52 (comment)) and should not occur in future versions.

We try to pin our main dependencies, to keep a little more control over how things update. Updating to 0.3.1 for async stream 0.3.1 isn't a problem, but should 0.3.1 have been 0.4?

I recommend using Cargo.lock for this purpose. Doing this using Cargo.toml is not intended and usually does not work.

@taiki-e taiki-e closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants