Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.3.1 release #52

Merged
merged 1 commit into from Apr 18, 2021
Merged

Prepare v0.3.1 release #52

merged 1 commit into from Apr 18, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 20, 2021

There have been some improvements since the previous release.

Changes:

@@ -18,7 +18,7 @@ syn = { version = "1", features = ["extra-traits", "full", "visit-mut"]}
quote = "1"

[dev-dependencies]
async-stream = { version = "0.3.0", path = "../async-stream" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid the circular dev-dependencies problems by removing the version from path dev-dependencies. See rust-lang/futures-rs#2305 for more.

homepage = "https://github.com/tokio-rs/async-stream"
repository = "https://github.com/tokio-rs/async-stream"
readme = "README.md"

[dependencies]
async-stream-impl = { version = "0.3.0", path = "../async-stream-impl" }
async-stream-impl = { version = "=0.3.1", path = "../async-stream-impl" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async-stream-impl is the implementation detail of async-stream, using = requirements would help to avoid some problems like rust-lang/futures-rs#2061

@taiki-e

This comment has been minimized.

@taiki-e taiki-e merged commit 8c22349 into tokio-rs:master Apr 18, 2021
@taiki-e taiki-e deleted the next branch April 18, 2021 15:59
SergioBenitez pushed a commit to SergioBenitez/async-stream that referenced this pull request May 21, 2021
SergioBenitez pushed a commit to SergioBenitez/async-stream that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants