Refactor storing URL params in extensions #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Mar 5, 2022
|
|
||
| let params = params | ||
| .iter() | ||
| .filter(|(key, _)| !key.starts_with(super::NEST_TAIL_PARAM)) |
There was a problem hiding this comment.
This seems a bit weird, will this special-cased parameter name go away with the next PR that normalizes path params?
There was a problem hiding this comment.
This has to do with nested opaque services. Its implemented as a wildcard route like /path/*NEST_TAIL_PARAM. So NEST_TAIL_PARAM is reserved by axum and shouldn't pollute the path params the user might see if using Path<HashMap<String, String>>.
There was a problem hiding this comment.
I see. I think it could use being more obviously special in that case, something like __private__axum_nest_tail_param.
jplatte
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on #678 but did refactoring of path params first. Thought I'd submit that as its own PR to make reviewing easier.