Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(benches): encloses bytes into test::black_box for clone benches #691

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Apr 10, 2024

Closes #690
Without it, it seems to me that compiler is able to inline the vtable, resulting in similar results for clone_shared and clone_arg_vec.

Closes tokio-rs#690
Without it, it seems to me that compiler is able to inline the vtable,
resulting in similar results for `clone_shared` and `clone_arg_vec`.
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 327615e into tokio-rs:master Apr 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should clone benchmark use use test::blackbox?
2 participants