Expand UDS tests #1143
Merged
Expand UDS tests #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
|
This will fail on MacOS, iOS, and Solaris until #1142 is merged. |
There was a problem hiding this comment.
Another small comment.
Also in #1145 I intend to remove the assert_ok and asser_err macros and merge expect_readiness with expect_events.
…ve-uds-tests Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Thomasdezeeuw
approved these changes
Nov 16, 2019
|
Can you rebase this on master? GitHub says there are conflicts. If its the same thing as last time (when I couldn't rebase, but you could), feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues have been opened related to the recently added UDS resources. The
issues are all behavior that tests should have caught. This PR splits
uds.rsinto
unix_stream.rs,unix_listener.rs, andunix_datagram.rstest files.Each of these test files tests the methods on it's respective resource as well
as
mio::Sourceimplementations.Signed-off-by: Kevin Leimkuhler kleimkuhler@icloud.com