feat: add no_eventfd cfg switch #1683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the use of `eventfd` on linux for the `Waker` implementation. Instead `pipe` is used as a fallback. Because some SGX runtimes like gramine do not have a secure emulation of the `eventfd` syscall, compiling with `RUSTFLAGS='--cfg no_eventfd'` will produce a more secure SGX application. See also: https://gramine.readthedocs.io/en/stable/manifest-syntax.html#allowing-eventfd Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
|
I'm going to do this myself as we likely want a similar flag for #1602, so I'll need to think a bit more about documentation and naming. Thanks for putting in the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the use of
eventfdon linux for theWakerimplementation. Insteadpipeis used as a fallback.Because some SGX runtimes like gramine do not have a secure emulation of the
eventfdsyscall, compiling withRUSTFLAGS='--cfg no_eventfd'will produce a more secure SGX application.See also:
https://gramine.readthedocs.io/en/stable/manifest-syntax.html#allowing-eventfd
Resolves: #1682