Add Apple visionOS support to v0.8 #1784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's first get #1773 in. |
Thomasdezeeuw
changed the title
|
@Thomasdezeeuw shall I pull in the changes from #1795 on this branch? The changes look similar/identical. |
|
@simlay is the main goal here adding support for Tokio? Because if so I rather merge tokio-rs/tokio#6635 and not add support to Mio v0.8. |
Ah yes. You are correct. I had not seen the mio v1 PR to Tokio. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1773 into the
v0.8.xbranch to enable tokio with thenetfeature flag to build visionos with a[patches.crates-io].I cherry-picked the commit from #1773 which brought in extra ci/make targets. There are unresolved issues in #1773 and there's still libc issues on rust-nightly rust-lang/rust#124560. I'll watch the other PRs and update this one accordingly.