Update to Mio v1 #6635
Draft
Update to Mio v1 #6635
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to add a test for tokio-rs/mio#1749 (review) not being breaking in Tokio? I think we may not have a test for this case. |
It seems like Tokio also has it's own version of What are you looking for in a test for this? |
|
E.g., calling |
Release 1 June 2023.
Bumps the MSRV to 1.70. One breaking changes is the removal of mio::net::SocketAddr, replacing it with std::os::unix::net::SocketAddr. The methods on the type should be the same. For some smaller OS, such as ESP-IDF and Hermit, it can now be compiled without RUSTFLAGS.
Doesn't seem like |
Thomasdezeeuw
force-pushed
the
thomas/mio-v1
branch
from
5800fb5
to
bafbcee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the MSRV to 1.70.
One breaking changes is the removal of mio::net::SocketAddr, replacing it with std::os::unix::net::SocketAddr. The methods on the type should be the same.
For some smaller OS, such as ESP-IDF and Hermit, it can now be compiled without RUSTFLAGS.