-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place Config::format
behind the format
feature flag.
#1022
Conversation
Please make this PR independent of #1020. My reasoning:
|
Valid points 😊 Though of doing this at first, I wanted to avoid having to fix the conflicts that would arise. Do you think that this will be merged before #1020? I wouldn't mind making this an independent PR is that's the case. |
Well, from my point of view:
The last commit of this branch seems like an improvement, so I think it makes sense to keep the PR open. I suggest making it independent and solve the merge conflict at a later time. |
Alrighty, a rebase later shouldn't be too hard anyway. I've now made this PR independent of the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to fix the merge conflict
Rebased and fixed suggestions! |
Thank you for your contribution |
Fixes: #1021
Depends upon: #1020.