-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
Why is |
it's removed in rust-native-tls. the functionality is moving one up in the stack, |
5934380
to
697b091
Compare
giving up fixing the osx tests for now. will revisit them when native-tls releases |
native-tls 0.2 is released! |
This would be a breaking change, correct? |
Yep |
Any chance of getting this merged soon? |
Also need this, this blocks upgrading I guess someone needs to figure out why the OS X build is failing (compilation fails due to missing function). |
I have a branch that passes the tests on macOS: https://github.com/djc/tokio-tls/tree/native-tls-0.2 @aep maybe pull my changes in your PR? Feel free to just squash my changes into yours. |
@djc some of the error messages are still different on osx apparantly |
Oh, I guess the error message may have changed between macOS 10.12 (on Travis) and 10.13 (which I have locally). I've pushed another commit to my branch that allows either version of the error message -- this seems a bit crappy perhaps, but it seems like an okay solution for the tests here. |
(I talked to Carl about this PR, and he mentioned he wants to merge #45 instead, which include these changes along with what's necessary to support modern tokio.) |
#45 was merged which contains also changes from this PR. So I think this one can be closed. |
This got done as part of #45. |
this well be needed once native-tls 0.2 gets released
sfackler/rust-native-tls#98