Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

prepare for native-tls 0.2 #43

Closed
wants to merge 4 commits into from
Closed

Conversation

aep
Copy link

@aep aep commented Jun 19, 2018

this well be needed once native-tls 0.2 gets released

sfackler/rust-native-tls#98

@mehcode
Copy link

mehcode commented Jun 19, 2018

Why is danger_connect_async_without_providing_domain_for_certificate_verification_and_server_name_indication removed?

@aep
Copy link
Author

aep commented Jun 19, 2018

it's removed in rust-native-tls. the functionality is moving one up in the stack,
see hyperium/hyper-tls@8370cde#diff-31bbf71c54bca98a0ae3d40a327af940R103

@aep aep force-pushed the native-tls-0.2 branch 3 times, most recently from 5934380 to 697b091 Compare June 19, 2018 19:09
@aep
Copy link
Author

aep commented Jun 20, 2018

giving up fixing the osx tests for now. will revisit them when native-tls releases

@sfackler
Copy link

native-tls 0.2 is released!

@carllerche
Copy link
Member

This would be a breaking change, correct?

@sfackler
Copy link

sfackler commented Jul 2, 2018

Yep

@tikue
Copy link

tikue commented Jul 11, 2018

Any chance of getting this merged soon?

@theduke
Copy link

theduke commented Jul 18, 2018

Also need this, this blocks upgrading tokio-imap.

I guess someone needs to figure out why the OS X build is failing (compilation fails due to missing function).
I can't since I don't have a mac.

@djc
Copy link

djc commented Jul 18, 2018

I have a branch that passes the tests on macOS:

https://github.com/djc/tokio-tls/tree/native-tls-0.2

@aep maybe pull my changes in your PR? Feel free to just squash my changes into yours.

@aep
Copy link
Author

aep commented Jul 19, 2018

@djc some of the error messages are still different on osx apparantly

@djc
Copy link

djc commented Jul 19, 2018

Oh, I guess the error message may have changed between macOS 10.12 (on Travis) and 10.13 (which I have locally). I've pushed another commit to my branch that allows either version of the error message -- this seems a bit crappy perhaps, but it seems like an okay solution for the tests here.

@djc
Copy link

djc commented Jul 22, 2018

(I talked to Carl about this PR, and he mentioned he wants to merge #45 instead, which include these changes along with what's necessary to support modern tokio.)

@izderadicka
Copy link

#45 was merged which contains also changes from this PR. So I think this one can be closed.

@carllerche
Copy link
Member

This got done as part of #45.

@carllerche carllerche closed this Aug 8, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants