macros: fix #[tokio::main] without rt-core
#2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tokio runtime provides a "shell" runtime when `rt-core` is not available. This shell runtime is enough to support `#[tokio::main`] and `#[tokio::test]. A previous change disabled these two attr macros when `rt-core` was not selected. This patch fixes this by re-enabling the `main` and `test` attr macros without `rt-core` and adds some integration tests to prevent future regressions.
carllerche
requested review from
vorot93,
hawkw,
taiki-e and
LucioFranco
and removed request for
vorot93 and
hawkw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tokio runtime provides a "shell" runtime when
rt-coreis notavailable. This shell runtime is enough to support
#[tokio::main] and`#[tokio::test].
A previous change disabled these two attr macros when
rt-corewas notselected. This patch fixes this by re-enabling the
mainandtestattr macros without
rt-coreand adds some integration tests to preventfuture regressions.
While I was in here, I also moved the entry point macros from
lib.rstoentry.rs. This will add space for future proc macros.