rt: add Runtime::shutdown_timeout
#2186
Conversation
Provides an API for forcing a runtime to shutdown even if there are still running tasks.
| /// | ||
| /// This currently is never returned, but might at some point in the future. | ||
| #[derive(Debug)] | ||
| pub(crate) struct ParkError { |
There was a problem hiding this comment.
Reshuffling internal code. This used to be public, which is why ParkError is opaque.
| let mut shared = self.spawner.inner.shared.lock().unwrap(); | ||
|
|
||
| if shared.shutdown { |
There was a problem hiding this comment.
The function can be called multiple times. First, by explicitly calling shutdown then by the drop handler calling shutdown. This prevents shutting down twice.
There was a problem hiding this comment.
Might be good if there was a comment in the code stating that, as well as on the PR?
|
@carllerche looks like rustfmt still needs to be run? |
| let mut shared = self.spawner.inner.shared.lock().unwrap(); | ||
|
|
||
| if shared.shutdown { |
There was a problem hiding this comment.
Might be good if there was a comment in the code stating that, as well as on the PR?
| use crate::park::{CachedParkThread, Park}; | ||
| use std::pin::Pin; | ||
| use std::task::Context; | ||
| use std::task::Poll::Ready; |
There was a problem hiding this comment.
minor style nit: some of these imports are now used by both block_on and block_on_timeout, should they be moved out of the individual functions?
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
Provides an API for forcing a runtime to shutdown even if there are
still running tasks.
Fixes #1923