Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixStream::poll_shutdown is not a no-op #2245

Merged
merged 2 commits into from
Feb 14, 2020
Merged

UnixStream::poll_shutdown is not a no-op #2245

merged 2 commits into from
Feb 14, 2020

Conversation

jonhoo
Copy link
Sponsor Contributor

@jonhoo jonhoo commented Feb 14, 2020

This brings UnixStream::poll_shutdown in line with TcpStream::poll_shutdown.

@jonhoo jonhoo mentioned this pull request Feb 14, 2020
Merged
@jonhoo
Copy link
Sponsor Contributor Author

jonhoo commented Feb 14, 2020

The test failure appears unrelated:
https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=4943&view=logs&j=d2df2122-3ea7-5c04-858c-c5c1184a8d43&t=62dc3779-9097-5a20-6957-9d4e6f212e93&l=69

@carllerche
Copy link
Member

Is there any way to test it? In theory, the peer should receive read readiness and get Ok(0)?

carllerche
carllerche approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice

@jonhoo
Copy link
Sponsor Contributor Author

jonhoo commented Feb 14, 2020

Added in 218f265. Funnily enough, the implementation of AsyncWrite for unix::WriteHalf already did shutdown and had a test for it, so this just makes that behavior consistent.

@carllerche
Copy link
Member

Great 👍 thanks. Merge on green!

@jonhoo jonhoo merged commit fc65951 into master Feb 14, 2020
@jonhoo jonhoo deleted the jonhoo/unix-socket-shutdown branch February 14, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonhoo @carllerche